-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): Pin eventlet
version
#880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Oct 20, 2020
temoto
added a commit
to eventlet/eventlet
that referenced
this pull request
Oct 21, 2020
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
@lobsterkatie thanks, WIP. May I suggest you'd use relaxed pin next time, like |
although i just only now realized it was pin in test requirements, so never mind |
temoto
added a commit
to eventlet/eventlet
that referenced
this pull request
Oct 21, 2020
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
temoto
added a commit
to eventlet/eventlet
that referenced
this pull request
Oct 21, 2020
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
temoto
added a commit
to eventlet/eventlet
that referenced
this pull request
Oct 22, 2020
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
temoto
added a commit
to eventlet/eventlet
that referenced
this pull request
Oct 22, 2020
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
temoto
added a commit
to eventlet/eventlet
that referenced
this pull request
Oct 22, 2020
…er_at_fork #660 getsentry/sentry-python#880 Could not reproduce problem without pytest, so normal production code was probably safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eventlet/eventlet#660.
Until that gets addressed, this pins us at a version we know doesn't break py2.7 tests.